Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISP 3A camera controls #5

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Add ISP 3A camera controls #5

merged 4 commits into from
Oct 7, 2020

Conversation

alex-luxonis
Copy link
Collaborator

No description provided.

@alex-luxonis alex-luxonis changed the base branch from main to develop September 28, 2020 22:01
@alex-luxonis alex-luxonis mentioned this pull request Sep 28, 2020
Merged
@alex-luxonis alex-luxonis requested a review from themarpe October 5, 2020 21:47
themarpe
themarpe requested changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having enum class you can probably shorten the enums as they are encapulated in the name of the enum class. Eg AutoFocusMode::AF_AUTO -> AutoFocusMode::AUTO

Also consider serialization from depthai-core PR

include/depthai-shared/metadata/camera_control.hpp Outdated Show resolved Hide resolved
@alex-luxonis alex-luxonis merged commit acc2f48 into develop Oct 7, 2020
@alex-luxonis alex-luxonis deleted the isp_3a_controls_develop branch October 7, 2020 21:13
@Luxonis-Brandon Luxonis-Brandon mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe Awaiting requested review from themarpe

@SzabolcsGergely SzabolcsGergely Awaiting requested review from SzabolcsGergely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-luxonis @themarpe @SzabolcsGergely